search

clirdlf / clir_theme

WordPress theme enhancements
https://www.clir.org
1 stars 0 forks source link

DHC: How to make text more visible on slider images #106

Closed nkferraiolo closed 6 years ago

nkferraiolo commented 6 years ago

Wayne,

Do you have any suggestions for how to make the text more visible on the slider images? I was thinking about adding a solid band of color behind the text like you did with the first CLIR landing-page mock-up, but I can't figure out how to do it in slider revolution. Do you have any suggestions?

Thanks!

Nikki

waynegraham commented 6 years ago

Did I answer this question this morning with the background shape?

nkferraiolo commented 6 years ago

Yes I think so, but let’s leave this thread open, so I remember to apply it to the other pages!

From: Wayne Graham notifications@github.com Reply-To: clirdlf/clir_theme reply@reply.github.com Date: Wednesday, October 11, 2017 at 12:20 PM To: clirdlf/clir_theme clir_theme@noreply.github.com Cc: Nicole Ferraiolo nferraiolo@clir.org, Author author@noreply.github.com Subject: Re: [clirdlf/clir_theme] DHC: How to make text more visible on slider images (#106)

Did I answer this question this morning with the background shape?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/clirdlf/clir_theme/issues/106#issuecomment-335865549, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AQwoIZL8kXhOwUCtzNOQn54gPGa3DW7Gks5srOrYgaJpZM4P1fdb.

waynegraham commented 6 years ago

With updated knowledge, the way you were doing this is probably way better. The trick is just to adjust the line height (on the initial edit view) to be larger than the font size (e.g. 48px font with a 5px border is 58px).