Closed unaiherran closed 3 months ago
cliss
commented
3 months ago Those are some great catches; added a bunch of new strings in 58c82df0bc8eb5a00080f94b6e64fdfac64a68b4.
Once you add those I'll merge this. :)
With regard to About Callsheet, I'm not too worried about that being English. With regard to the log file, that's an excellent catch, but it's a little bit more effort to unwind, which I'll have to get to later.
unaiherran
commented
3 months ago New strings have been added and translated.
And opened a can of worms that will surely bite me(a little bit) and cliss (much, much more) in the future. When I first translated 'You may know them from' I didn't realized that 'them' is a neutral pronoun, that has not easy translation in Spanish.
I check what they do in IMDB and they use a generic masculine form no matter if it's male or female, and this is the solution I used. I don't know if it's possible to have different strings depending on the gender
When pressing Where to watch there is 3 tabs for Subscription, Rent or Buy. Those strings are not localized. (I don't know if they are provided by JustWatch, so maybe there is no posibility to localize them, but just in case they are generated by you)
Also in that screen the countries in the list are translated (Probably is a setting of the control) but on Region Override and Language Override in Settings screen, the country and language lists are in English. (I don't know much (any) of Swift UI, so I'm not really sure if its an easy or hard fix, but just for you to know)
'Know for: Directing / Acting / Editing'... probably is not localized. Probably this data cames directly from TMDB, but if it's not, it should be localized
Finally, and I know this is a really nitpicking comment, in the app description for iOS/Vision OS (or anywhere else) I think you should put a disclaimer. Since all the summaries for the movies or TV Shows are from The Movie Database, they are all in English, so a Localized app would display some information in English. Someone will complain.
Besides the first corrections to the settings screens I found some strings that are still in English
Spoiler settings
Settings
Dont know if its a Test Flight Issue but:
are not localized
About Callsheet
The only localized part is about Cassey Liss Erin, Declan, Mikaela.... ATP listeners is not localized
Email Feedback
In the log.txt that is sent with the email, the line
21/05/2024 07:39:45 ℹ️ [UserSettings] ⚙️ Credits shown now set to Películas y series
Películas y series is localized. Since its a log, I think it would be easier for you not to localied that so you can troubleshoot it better. If its localized in Korean you will have something like 프로그램