Potentially Split Up Two Incongruent Uses of "Known for"?

cliss / callsheet-localizations

Localization Files for Callsheet

6 stars 29 forks source link

Closed cliss closed 3 months ago

cliss commented 3 months ago

@cliss: Perhaps use two different keys and make sure the English localization handles them properly?

cliss commented 3 months ago

@DonSqueak Can you explain a little better so I understand, please?

There are two different places I use the exact string Known For:

A person is "Known For Directing/Acting/etc"
In the Persnickety Preferences, meaning "Show me a list of stuff this person is in yes/no"

You're saying German would prefer different translations for these two?

DonSqueak commented 3 months ago

Ideally yes.

A person is "Known For Directing/Acting/etc" --> Bekannt für
In the Persnickety Preferences, meaning "Show me a list of stuff this person is in yes/no" --> Bekannt aus or Man kennt sie aus

The second of the two, when left as Bekannt für sounds a bit... wonky.

cliss commented 3 months ago

Added in 3070201b84dd729ba9a4f090a709de4af9898c22.

For every language that had a translation for Known For, I copied the one that pre-existed. May be worth a second look though.

DonSqueak commented 3 months ago

Solved! Thank you!