search

cliss / callsheet-localizations

Localization Files for Callsheet
6 stars 29 forks source link

Polish: BIG translation drop; French: typo; German: miscellaneous tiny stuff #87

Closed DonSqueak closed 2 months ago

DonSqueak commented 2 months ago

@spitfire Can you review please?

@cliss fyi, I had lots of time today ;)

DonSqueak commented 2 months ago

Bunch of review incorporated. Maybe it would now help if we tested this state in TestFlight? What say you, @spitfire ?

spitfire commented 2 months ago

Sure, let's go ahead. It's always better to see the changes live, in use.

DonSqueak commented 2 months ago

Funnily enough, work on the Polish version clarified some mistranslations for me that I still had in the German version. Context is king.

cliss commented 2 months ago

Will merge in ~an hour unless someone stops me…

cliss commented 2 months ago

Super close on Polish:

Screenshot 2024-06-04 at 9 11 27 AM
spitfire commented 2 months ago

Super close on Polish: Screenshot 2024-06-04 at 9 11 27 AM

I've asked you about the first one before - it looks like a duplicate, probably from before you've figured out plularization - is it still needed? I'll sync my repo and try to complete these.

cliss commented 2 months ago

I've asked you about the first one before - it looks like a duplicate, probably from before you've figured out plularization - is it still needed? I'll sync my repo and try to complete these.

Yeah, they're still used, and Xcode is still unhappy about them not being there.

For what it's worth, every time I update the README, I've had Xcode re-generate everything based on the strings it finds my using in the app.

Not to say that it's always perfect, but usually it actually gets it right. 😏