Add Workspace Audit Picker

clivewatson / KQLpublic

My useful KQL and Azure Monitor workbooks (Public)

MIT License

112 stars 50 forks source link

Add Workspace Audit Picker #3

Open richlilly2004 opened 3 years ago

richlilly2004 commented 3 years ago

I have updated this in mine, but would love another picker up top next to the workspace standard picker as we often have clients or recommend a separate audit workspace.

I can do a PR if you prefer, but I see you're working on 1.4.8 and may be able to toss it in :)

CliveW-MSFT commented 3 years ago

Hi, can you share what you mean (maybe your amended JSON file), I have just finished 1.4.8 (yesterday) but certainly can add this to the next one. Thanks Clive

richlilly2004 commented 3 years ago

Hi, can you share what you mean (maybe your amended JSON file), I have just finished 1.4.8 (yesterday) but certainly can add this to the next one. Thanks Clive

Just pushed a PR for review

CliveW-MSFT commented 3 years ago

As this is just for the LAQueryLogs - I'm thinking of having the Filter in that section, not as a global one (it defaults to the current selected Workspace)? Does this work for you, that way you can still see the selected Workspace, and any other one for Auditing

richlilly2004 commented 3 years ago

As this is just for the LAQueryLogs - I'm thinking of having the Filter in that section, not as a global one (it defaults to the current selected Workspace)? Does this work for you, that way you can still see the selected Workspace, and any other one for Auditing

I like that, and makes sense, unless you plan on unioning both for other views.

CliveW-MSFT commented 3 years ago

I also considered this:

Which will put the official Workbook for Audit into a context blade, that pops out?

richlilly2004 commented 3 years ago

I also considered this:

Which will put the official Workbook for Audit into a context blade, that pops out?

I'm really fine with either, but if the pop-out experience is per query, may not look great