add timeout to put/post methods

cliviu74 / wallbox

Python Module interface for Wallbox EV chargers api

Apache License 2.0

62 stars 22 forks source link

add timeout to put/post methods #51

Closed cliviu74 closed 5 months ago

cliviu74 commented 5 months ago

Fix for #49

add timeout to post/put requests
minor code formatting

tmenguy commented 5 months ago

great, the only issue I has with this is the variable name : it is called GetTimeout .... and we use it everywhere, I preferred th let it as it is to no break any compatibility. Anyway great to have the fix, hope you can merge it soon so we can merge the #46 right after

cliviu74 commented 5 months ago

Agreed with the *getTimeout, should be more general. I'll think about a refactor, pending finding some time.