clj-commons / aleph

Asynchronous streaming communication for Clojure - web server, web client, and raw TCP/UDP

http://aleph.io

MIT License

2.54k stars 241 forks source link

Websockets heartbeat handler throws NPE if no timeout specified. #552

Closed wardle closed 4 years ago

wardle commented 4 years ago

Fixed in linked pull request. If 'timeout' property of heartbeats configuration is truly optional, then timeout can be nil, and clojure's pos? throws an NPE. #551

kachayev commented 4 years ago

Good catch. Thanks a lot!

kachayev commented 4 years ago

551 is merged. Thanks!

wardle commented 4 years ago

Thanks - and many thanks indeed for all of your hard work on this - cc @ztellman - it's really excellent.