Closed kachayev closed 1 year ago
@gsnewmark Thanks a lot for the review! Let me address obviously wrong things and get back with more comments 😀
Quick update
I spent a bit of time already trying to rebase this branch on master. It's not that easy but the number of tests that have been added are really valuable.
Superseded by #658
Not all the changes from this PR have been included as some were significant in terms of impact. However, the unit tests have been included and some fixes have been made.
There are quite a few changes introduced here. Would be more than happy to get comments before merging into
1.0.0
branch 😀Notably:
error-logger
parameter is added for HTTP client/server, Websocket client/server to customize exceptions logging for those exceptions that could not be visible to user's code in any other way (e.g. something that happens within HTTP server pipeline)TimeoutException
handlers are fixed in HTTP client (to avoid double disposal of the connections):aleph/interrupted?
flag is introduce as a part of ring request object for HTTP server, making it's possible to track if streaming body was closed because of an error (e.g. decoder exception, premature close, etc)