search

clj-commons / aleph

Asynchronous streaming communication for Clojure - web server, web client, and raw TCP/UDP
http://aleph.io
MIT License
2.54k stars 241 forks source link

Fix websocket-upgrade-request? for Firefox WebSocket upgrade requests. #562

Closed xorgy closed 3 years ago

xorgy commented 3 years ago

Fixes #561

slipset commented 3 years ago

Thanks a lot xorgy. Could you please also provide a test which shows that this doesn't break existing functionality, ie that it works when only sending "Upgrade" in the connection header, as well as when sending "keep-alive,Upgrade"?

xorgy commented 3 years ago

Thanks a lot xorgy. Could you please also provide a test which shows that this doesn't break existing functionality, ie that it works when only sending "Upgrade" in the connection header, as well as when sending "keep-alive,Upgrade"?

Sure, I'll write a test for it. Probably good to have one anyway, given that there are zero tests for this function right now.

xorgy commented 3 years ago

Let me know if the test I've added is satisfactory, I can squash it in.

xorgy commented 3 years ago

Thank you as well.