search

clj-commons / aleph

Asynchronous streaming communication for Clojure - web server, web client, and raw TCP/UDP
http://aleph.io
MIT License
2.54k stars 241 forks source link

0.4.7-rc1 compiled with java17 #580

Closed xificurC closed 2 years ago

xificurC commented 2 years ago

The latest jar seems to be deployed with java17 compiled java class files. Is this intended?

KingMob commented 2 years ago

@xificurC Whoops. No, it wasn't. I'll cut an rc2 compiled for Java 8.

danielcompton commented 2 years ago

You can set the java options like this so that you can compile with newer JDKs but still include support for older ones:

https://github.com/clj-commons/primitive-math/blob/4d6f219860a66983913a034f878aec442473f33e/project.clj#L17

I think source and target set to 1.8 should work.

KingMob commented 2 years ago

Thanks @danielcompton.

Erik and I were also discussing a more comprehensive deployment process based on http://slipset.github.io/posts/deploying-to-clojars. We'd already done it for byte-streams, but it would be good to extend that to aleph and manifold, too. Manual deployment is obviously error-prone 😄