Add missing type hint on websocket-server-handler

clj-commons / aleph

Asynchronous streaming communication for Clojure - web server, web client, and raw TCP/UDP

http://aleph.io

MIT License

2.54k stars 241 forks source link

Add missing type hint on websocket-server-handler #586

Closed arnaudgeiser closed 2 years ago

arnaudgeiser commented 2 years ago

Description

A type hint was missing causing reflection warning on the aleph.http.server/websocket-server-handler function

Impacts

None

Testing done

Evaluating aleph/http/server/clj :

Before

Reflection warning, /home/arnaudgeiser/code/aleph/src/aleph/http/server.clj:686:16 - call to method close on io.netty.handler.codec.http.websocketx.WebSocketServerHandshaker can't be resolved (argument types: io.netty.channel.Channel, java.lang.Object).

After

(Nothing)

KingMob commented 2 years ago

Looks good to me. Thanks!