search

clj-commons / aleph

Asynchronous streaming communication for Clojure - web server, web client, and raw TCP/UDP
http://aleph.io
MIT License
2.54k stars 241 forks source link

Disable logger when running tests #599

Closed arnaudgeiser closed 2 years ago

arnaudgeiser commented 2 years ago

Description

Some tests that are testing edge cases log the Exception before re-throwing it [1][2]. It's not a desired behavior when running the tests.

I propose to disable the logger when running on test profile. An alternative would be to remove the log here, but it would be a breaking change. In the future, we might be pass a noop error-logger when the error handling PR will be merged. https://github.com/clj-commons/aleph/pull/553

[1] : https://github.com/clj-commons/aleph/blob/36b2859a14fc12cb2665e64f098996115db21852/src/aleph/http/core.clj#L548 [2] : https://github.com/clj-commons/aleph/blob/master/test/aleph/http_test.clj#L276-L281

Testing done

> lein test

lein test aleph.http-continue-test

lein test aleph.http-test

lein test aleph.http.client-middleware-test

lein test aleph.http.client-test

lein test aleph.http.core-test

lein test aleph.http.multipart-test

lein test aleph.ring-test

lein test aleph.tcp-ssl-test

lein test aleph.tcp-test

lein test aleph.udp-test

lein test aleph.websocket-test
KingMob commented 2 years ago

OTOH, if they really hate our logs, they can suppress our namespaces/packages in logback.xml, so maybe it's not a big deal.