netty: allow setting eventloop group shutdown grace values

clj-commons / aleph

Asynchronous streaming communication for Clojure - web server, web client, and raw TCP/UDP

http://aleph.io

MIT License

2.54k stars 241 forks source link

Closed pyr closed 2 years ago

pyr commented 2 years ago

addresses #638

pyr commented 2 years ago

Circle-CI is not configured hence the test issue, but tests run fine for me locally. (I recommend viewing the diff with whitespace changes disabled: https://github.com/clj-commons/aleph/pull/639/files?diff=split&w=1)

pyr commented 2 years ago

I'll tackle the comments later today, thanks for the review!

KingMob commented 2 years ago

Looking good to me.

But what's that weird CircleCI warning? Let me check with Erik on slack.

KingMob commented 2 years ago

I'm not sure we need to hold up the PR for the Circle issue. Erik doesn't recognize it. I can't tell where it's coming from. I guess we'll see.

Merging for now