clj-commons / aleph

Asynchronous streaming communication for Clojure - web server, web client, and raw TCP/UDP
http://aleph.io
MIT License
2.54k stars 241 forks source link

multipart: support file-name when encoding memory data #668

Closed p-himik closed 1 year ago

p-himik commented 1 year ago

Fixes #667

Renamed filename -> file-name to be consistent with other parameters. It wasn't public so no breckage. Removed an explicit "" file name because Netty adds it on its own.

p-himik commented 1 year ago

Seems like the tests just got stuck. Also happened on my local machine once for some reason, only with the UDP tests. And I don't have a permission to re-run the tests.

arnaudgeiser commented 1 year ago

Me neither, but it's all good

❯ lein test
Compiling 5 source files to /home/arnaudgeiser/code/aleph/target/classes
warning: [options] bootstrap class path not set in conjunction with -source 8
1 warning
Compiling 5 source files to /home/arnaudgeiser/code/aleph/target/classes
warning: [options] bootstrap class path not set in conjunction with -source 8
1 warning

lein test aleph.classloader-test

lein test aleph.http-continue-test

lein test aleph.http-test

lein test aleph.http-timeout-test

lein test aleph.http.client-middleware-test

lein test aleph.http.client-test

lein test aleph.http.core-test

lein test aleph.http.multipart-test

lein test aleph.http.server-test

lein test aleph.netty-test

lein test aleph.ring-test

lein test aleph.tcp-ssl-test

lein test aleph.tcp-test

lein test aleph.udp-test

lein test aleph.websocket-test

Ran 92 tests containing 1268 assertions.
0 failures, 0 errors.
arnaudgeiser commented 1 year ago

Also happened on my local machine once for some reason, only with the UDP tests.

It might be due to the time to shut down the UDP socket since we introduced many more tests [1]. I did it for the TCP tests already, but I should probably do the same for the UDP ones.

[1] https://github.com/clj-commons/aleph/blob/master/test/aleph/udp_test.clj

arnaudgeiser commented 1 year ago

Thank you Eugene!