clj-commons / aleph

Asynchronous streaming communication for Clojure - web server, web client, and raw TCP/UDP
http://aleph.io
MIT License
2.54k stars 241 forks source link

Fix backwards-compatibility on transport + doc #672

Closed arnaudgeiser closed 1 year ago

arnaudgeiser commented 1 year ago

Description

When randomly reviewing some parts of the code I discovered that netty/create-client (the backwards-compatibility function) is sending the epoll? key instead of the transport one. This function is not used (anymore) inside Aleph but there is a low chance that some Aleph users might still use it with some workarounds... who knows.

So it can be called a regression where the worst case scenario is that the client won't even start. But I don't believe everyone will be impacted.

I also added some dots on the documentation for conformance and remove some white spaces.