Lein2deps update

[jeroenvandijk]

This change updates the lein2deps script to v0.1.0.

This update generates the following improvements:

• a more readable output of deps (no namespace maps) and it maintains the order as in the original project.clj.

• It now adds resources. In this case that means the clj-kondo configs are now also available to people using Aleph as git dep.

• :mvn/repos is now being added according to :repositories in project.clj

[arnaudgeiser]

Sounds like the SHA for deps.edn is hard-coded inside lein2deps. [1] I basically reverted your last commit. Would it be fine for you?

[1] : https://github.com/borkdude/lein2deps/blame/main/src/lein2deps/internal.clj#L50

[jeroenvandijk]

@arnaudgeiser Oh I somehow missed that. Reverting the last commit is fine by me. Thank you!

[KingMob]

Looks good to me.

I wonder if we can remove those :repositories lines. I don't think we pull from anything other than maven.

[DerGuteMoritz]

Changes lgtm, too. I suggest we squash on / before merge.

I wonder if we can remove those :repositories lines. I don't think we pull from anything other than maven.

@KingMob I think you're right. I tried to remove them and then ran lein repl, lein jar and lein test successfully (using a fresh local m2 repo). Anything else you can think of? Otherwise let's do it!

[arnaudgeiser]

@jeroenvandijk : Can we ask you to remove all the :repositories on the project.clj file?

[arnaudgeiser]

Thanks... This test seems to be a bit flaky though (not related to your changes)

ERROR in (test-client-errors-handling) (HttpVersion.java:116)
response body larger then content-length
expected: (= "h" (-> (http-get (str "http://localhost:" port)) (d/timeout! 1000.0) deref :body bs/to-string))
  actual: java.lang.IllegalArgumentException: invalid version format: ELLO
 at io.netty.handler.codec.http.HttpVersion.<init> (HttpVersion.java:116)
    io.netty.handler.codec.http.HttpVersion.valueOf (HttpVersion.java:78)
    io.netty.handler.codec.http.HttpResponseDecoder.createMessage (HttpResponseDecoder.java:155)
    io.netty.handler.codec.http.HttpObjectDecoder.decode (HttpObjectDecoder.java:273)
    io.netty.handler.codec.http.HttpClientCodec$Decoder.decode (HttpClientCodec.java:239)
    io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection (ByteToMessageDecoder.java:529)
    io.netty.handler.codec.ByteToMessageDecoder.callDecode (ByteToMessageDecoder.java:468)
    io.netty.handler.codec.ByteToMessageDecoder.channelRead (ByteToMessageDecoder.java:290)
    io.netty.channel.CombinedChannelDuplexHandler.channelRead (CombinedChannelDuplexHandler.java:251)
    io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead (AbstractChannelHandlerContext.java:442)
    io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead (AbstractChannelHandlerContext.java:420)
    io.netty.channel.AbstractChannelHandlerContext.fireChannelRead (AbstractChannelHandlerContext.java:412)
    io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead (DefaultChannelPipeline.java:1410)
    io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead (AbstractChannelHandlerContext.java:440)
    io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead (AbstractChannelHandlerContext.java:420)
    io.netty.channel.DefaultChannelPipeline.fireChannelRead (DefaultChannelPipeline.java:919)
    io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read (AbstractNioByteChannel.java:166)
    io.netty.channel.nio.NioEventLoop.processSelectedKey (NioEventLoop.java:788)
    io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized (NioEventLoop.java:724)
    io.netty.channel.nio.NioEventLoop.processSelectedKeys (NioEventLoop.java:650)
    io.netty.channel.nio.NioEventLoop.run (NioEventLoop.java:562)
    io.netty.util.concurrent.SingleThreadEventExecutor$4.run (SingleThreadEventExecutor.java:997)
    io.netty.util.internal.ThreadExecutorMap$2.run (ThreadExecutorMap.java:74)
    manifold.executor$thread_factory$reify__942$f__943.invoke (executor.clj:70)
    clojure.lang.AFn.run (AFn.java:22)
    io.netty.util.concurrent.FastThreadLocalRunnable.run (FastThreadLocalRunnable.java:30)
    java.lang.Thread.run (Thread.java:750)

[arnaudgeiser]

All good for me, thanks Jeroen!