search

clj-commons / aleph

Asynchronous streaming communication for Clojure - web server, web client, and raw TCP/UDP
http://aleph.io
MIT License
2.54k stars 241 forks source link

"Possibly confusing dependencies found" regression in 0.6.1 #676

Closed bitti closed 1 year ago

bitti commented 1 year ago

When running lein deps :tree in a project which includes aleph 0.6.1 as dependency, I get:

Possibly confusing dependencies found:
[aleph "0.6.1"] -> [org.clojure/tools.logging "1.1.0" :exclusions [org.clojure/clojure]]
 overrides
[aleph "0.6.1"] -> [manifold "0.3.0"] -> [org.clojure/tools.logging "1.2.4" :exclusions [org.clojure/clojure]]

So aleph includes a transitive dependency which depends on org.clojure/tools.logging 1.2.4 while having a direct dependency on org.clojure/tools.logging 1.1.0. I suggest updating the direct dependency to match the 1.2.4 version. This doesn't happen in aleph 0.6.0.

KingMob commented 1 year ago

Thanks for catching this

bitti commented 1 year ago

Thanks for fixing this. But do you know when you do a release which includes the fix?

KingMob commented 1 year ago

@bitti Sorry, been hard at work adding HTTP/2 support to Aleph. If it's critical, I can cut a quick patch release.

bitti commented 1 year ago

No problem, thanks for your hard work! No it's not critical, I was just wondering if there is a timeline.

KingMob commented 1 year ago

@bitti A bunch of changes had accumulated, so I just released 0.6.2: https://clojars.org/aleph/versions/0.6.2