Drop fixed HTTP server shutdown timeout

clj-commons / aleph

Asynchronous streaming communication for Clojure - web server, web client, and raw TCP/UDP

http://aleph.io

MIT License

2.54k stars 241 forks source link

Drop fixed HTTP server shutdown timeout #709

Closed DerGuteMoritz closed 4 months ago

DerGuteMoritz commented 4 months ago

This is a WIP artifact from the patch which introduced HTTP/2 support. It is no longer needed and dropping it reduces test suite runtime from roughly 5 minutes to roughly 40 seconds.

See https://github.com/clj-commons/aleph/pull/687#discussion_r1402354975 for discussion.

DerGuteMoritz commented 4 months ago

Aha, coincidentally, this patch appears to fix the timeout issue mentioned here, as well! Either that, or some environmental factor at CircleCI has changed in the meantime...

KingMob commented 4 months ago

Thanks for following up on this. LGTM. Though I suspect it may only be masking any resource leak issue...

DerGuteMoritz commented 4 months ago

Though I suspect it may only be masking any resource leak issue...

If so, #708 will hopefully uncover it!