search

clj-commons / aleph

Asynchronous streaming communication for Clojure - web server, web client, and raw TCP/UDP
http://aleph.io
MIT License
2.54k stars 241 forks source link

Improve docs for `http/connection-pool`'s HTTP/2 support and ALPN config #729

Closed DerGuteMoritz closed 5 months ago

DerGuteMoritz commented 5 months ago

Prompted by #727

KingMob commented 5 months ago

Are you sure you want to mandate ALPN and update the docs, instead of updating the code?

arnaudgeiser commented 5 months ago

Are you sure you want to mandate ALPN and update the docs, instead of updating the code?

I think we should close the documentation PR and aim at updating the code with the snippet above.

DerGuteMoritz commented 5 months ago

Are you sure you want to mandate ALPN and update the docs, instead of updating the code?

No I would prefer to update the code, as well. Will prepare a patch for that separately and once it's landed, we can get back to the doc update here.

I think we should close the documentation PR and aim at updating the code with the snippet above.

The doc update is mostly orthogonal, only the wording about the ALPN config requirement would have to be changed once we've made it (more) optional again.