search

clj-commons / byte-streams

A Rosetta stone for JVM byte representations
417 stars 33 forks source link

Lein javac options break on JDKs >= 12 #40

Closed KingMob closed 3 years ago

KingMob commented 3 years ago

This line in project.clj is causing the problem: :javac-options ["-target" "1.6" "-source" "1.6"]

It's not a blocker for those consuming by jar, it's only if you want to fire up a REPL and poke around the code.

❯ jenv shell 12
~/Documents/Code/byte-streams |HEAD✓
❯ lein do clean, compile, repl
Compiling 3 source files to /Users/matthew/Documents/Code/byte-streams/target/classes
warning: [options] bootstrap class path not set in conjunction with -source 6
error: Source option 6 is no longer supported. Use 7 or later.
error: Target option 6 is no longer supported. Use 7 or later.
Compilation of Java sources(lein javac) failed.
slipset commented 3 years ago

I've moved this from the default profile to the ci profile, so this should be fixed now. Please reopen if the problem persists