search

clj-commons / byte-streams

A Rosetta stone for JVM byte representations
417 stars 33 forks source link

Resolve boxed math warnings #64

Closed valerauko closed 1 year ago

valerauko commented 1 year ago
KingMob commented 1 year ago

You know, we already use clj-commons.primitive-math elsewhere, we should probably do the same here for consistency. Sorry, can you change it?

valerauko commented 1 year ago

@KingMob late, but I updated to using primitive-math. Is this what you were referring to?

Are the boxed math warning around line 130 in graph.clj also unfixable due to https://github.com/clj-commons/byte-streams/issues/68 ?

valerauko commented 1 year ago

we've been using p as the alias for primitive-math elsewhere, instead of m

I used m because p was already taken. Should I change the existing alias to something else?

KingMob commented 1 year ago

I think p is more consistent with existing primitive-math examples, and would prefer proto for protocols.

valerauko commented 1 year ago

Eastwood fails with the reflection on the (.type dst) which can't be fixed according to the comment

KingMob commented 1 year ago

I think this is fine for now. Thanks!

Something is still wrong about that def-conversion/AOT problem, but we're not going to fix it here. It seemed related to CLJ-1650/1741, but the timing is wrong; that bug was fixed in Clojure 1.8. I wonder if it's related to Potemkin and deftype+?

valerauko commented 1 year ago

Thanks! I guess the warnings in manifold are next!