search

clj-commons / byte-streams

A Rosetta stone for JVM byte representations
417 stars 33 forks source link

Drop type-hints from `assoc-conversion` to work around AOT issue #69

Closed DerGuteMoritz closed 1 year ago

DerGuteMoritz commented 1 year ago

Since this function is usually not called at runtime, the reflection performance penalty should be tolerable.

Fixes #68

KingMob commented 1 year ago

Does it also fix #34?

DerGuteMoritz commented 1 year ago

Does it also fix #34?

Pretty sure it would (this patch was derived from the workaround in that ticket's description). However, according to https://github.com/clj-commons/byte-streams/issues/34#issuecomment-1138168703 it wasn't reproducible anymore in that particular context so I didn't try anymore.

Can you make Eastwood stop complaining about the changes?

Done!

DerGuteMoritz commented 1 year ago

Indeed, that's unfortunate :shrug:

Note that I don't have merge rights myself here so you'll have to do the honors :slightly_smiling_face:

KingMob commented 1 year ago

Dammit, let me see about adding you as a contributor

KingMob commented 1 year ago

@DerGuteMoritz Try merging now

DerGuteMoritz commented 1 year ago

Thanks! :pray: