clj-commons / camel-snake-kebab

A Clojure[Script] library for word case conversions
https://clj-commons.org/camel-snake-kebab/
Eclipse Public License 1.0
475 stars 49 forks source link

Upgrade to 1.7, cljx->cljc, cemerick.test->doo #35

Closed bensu closed 8 years ago

bensu commented 8 years ago

After upgrading to clojure 1.7 to use reader conditionals, cljsbuild needed to be updated to its latest version, and cemerick.test replaced by cljs.test to set the tests + lein-doo to run the tests.

bensu commented 8 years ago

I apologize for the extra commits! It's hard to test Travis locally :) When I correct Travis CI I'll squash the commits and make another PR.

Also, let me know if/where you want me to add a Change notice.

bensu commented 8 years ago

lein 2.5.1 doesn't recognize cljc files when running tests. I'm trying to configure Travis to use lein 2.5.2 which fixed the issue (see https://github.com/technomancy/leiningen/issues/1940 for more info).

The builds pass, but it is not running the tests in the JVM, only in node.

qerub commented 8 years ago

Thanks! :bow:

.

When I correct Travis CI I'll squash the commits and make another PR.

You don't have to make another PR; just change what commit bensu:cljc points to.

Also, let me know if/where you want me to add a Change notice.

I'll take care of updating NEWS.md. I'll also add you to AUTHORS.md.

.

Cleanup the commit history and I'll merge. See if you can request the merge to be against master instead of stable too.

stoyle commented 8 years ago

Is this complete, or do you need help getting it complete?

We'd very much like to use the camel-snake-kebab for our ClojureScript app, but would like to avoid the cljx overhead.

qerub commented 8 years ago

@stoyle AFAIK it is complete. Thanks for the poke. I'll get it merged this weekend!

stoyle commented 8 years ago

Cool, thanks!

qerub commented 8 years ago

Squashed and merged in 90edf7e98bef29e6ad8a7c7e67adfebfef636cf5.

qerub commented 8 years ago

@stoyle Can you give the 0.4.0-SNAPSHOT build on Clojars a spin?

stoyle commented 8 years ago

Works great! Included it into our app, and works as expected.

Also done a ->kebab-case-keyword and back to ->camelCaseString, starting point and result ends up being equal.

qerub commented 8 years ago

@stoyle Thanks! I'll do a proper release during the weekend and notify you.

qerub commented 8 years ago

@stoyle It is done: https://clojars.org/camel-snake-kebab/versions/0.4.0

stoyle commented 8 years ago

Thanks!