Closed viebel closed 4 years ago
Tests are not passing.
@qerub Code fixed. Tests are passing now.
camel-snake-kebab
running on KlipseI checked the build logs and saw errors like E: Failed to fetch http://deb.debian.org/debian/pool/main/s/systemd/systemd_232-25+deb9u6_amd64.deb 404 Not Found
. I think an apt-get update
before apt-get install software-properties-common
would resolve those.
The tests pass now (including planck).
I created a docker image that contains planck binary.
Let me know if you are open to this solution.
Another option is to run the shell commands that install planck
on each CI build.
That what it would take:
RUN wget https://planck-repl.org/releases/2.25.0-share/plk && chmod a+x plk
RUN wget https://planck-repl.org/releases/2.25.0-debian-9.0-x86_64/planck && chmod a+x planck && sudo mv planck /usr/local/bin
RUN sudo apt-get install clojure
RUN sudo apt-get install libjavascriptcoregtk-4.0-18
RUN sudo apt-get install libzip4
I created a docker image that contains planck binary. Let me know if you are open to this solution. Another option is to run the shell commands that install
planck
on each CI build.
I'd very much prefer the alternative option and be self-contained even if CI builds will be slower.
Thanks a lot for all your work so far! We're almost there!
Done. It's my pleasure to promote Self Hosted Cljs.
This install the Clojure CLI which is required to run planck
On Fri, Aug 7, 2020 at 3:53 PM Christoffer Sawicki notifications@github.com wrote:
@qerub commented on this pull request.
In .circleci/config.yml https://github.com/clj-commons/camel-snake-kebab/pull/67#discussion_r467020760 :
@@ -38,5 +38,11 @@ jobs:
- ~/.m2 key: v1-dependencies-{{ checksum "project.clj" }}
install planck
- run: wget https://planck-repl.org/releases/2.25.0-debian-9.0-x86_64/planck && chmod a+x planck && sudo mv planck /usr/local/bin
- run: sudo apt-get install clojure
Probably last question/remark: Is this installation of Clojure required? If so, why?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/clj-commons/camel-snake-kebab/pull/67#pullrequestreview-463286630, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHJKPUHXRO4QF33MON54TLR7P2LBANCNFSM4PK3FCOA .
-- Yehonathan Sharvit Author, Speaker, Developer
@qerub Could you release a version that includes this change? Thanks
@qerub Could you release a version that includes this change?
Awesome!
Solve #46