search

clj-commons / clj-yaml

YAML encoding and decoding for Clojure
Other
122 stars 26 forks source link

Add :code-point-limit option to accept bigger documents #103

Closed pitalig closed 1 year ago

pitalig commented 1 year ago

By default, snakeYAML limits the document size to 3 mb for security reasons and you need to add change the code-point-limit on the LoaderOptions to be able to parse bigger documents. This makes that configuration available on the public API.

Closes https://github.com/clj-commons/clj-yaml/issues/94

PS: I'm quite new to open source contributions, so feedbacks are more than welcome.

lread commented 1 year ago

Thanks, this looks really good @pitalig!

The only thing I see missing is an entry in the changelog.

borkdude commented 1 year ago

LGTM too :)

lread commented 1 year ago

For posterity and clarity, there is an upcoming fix in SnakeYAML around code-point-limit and multiple documents. We'll pick up this fix when SnakeYAML cuts its next release (probably v2.1).

pitalig commented 1 year ago

The only thing I see missing is an entry in the changelog.

Updated. 😄 Dumb question, should I trigger the merge or any release workflow? Or you take care of this?

lread commented 1 year ago

Dumb question, should I trigger the merge or any release workflow? Or you take care of this?

@pitalig this happens automatically when a GitHub repository maintainer merges your PR to master.

The maintainers also decide when to release and initiate the release workflow. We have been waiting for SnakeYAML 2.1 before we cut a next release.

lread commented 1 year ago

If you need this change in your project now, you could: