search

clj-commons / clj-yaml

YAML encoding and decoding for Clojure
Other
120 stars 25 forks source link

Fix zero leading number with quotes #54

Closed borkdude closed 2 years ago

borkdude commented 2 years ago

The upgraded dep is a temporary workaround until 1.33 is released. This PR can be updated once that is done.

I deployed the SnakeYAML lib from a local fork to clojars.

https://github.com/borkdude/SnakeYAML/blob/053b63daa895294dcf55a745aa48f06dfff1dea4/build.clj#L21

lread commented 2 years ago

I guess we could merge this @borkdude? Or would you rather wait for a couple of days to see if 1.33 drops?

borkdude commented 2 years ago

The problem is that when people have multiple versions SnakeYAML in their dependency tree, my fork and the original one, you will get both and it becomes unpredictable which one is used. For bb I don't have this problem, but in the open world it is a problem. So it's better to wait for 1.33.

lread commented 2 years ago

Right, of course, thanks, for general use, different maven coords but same package names = confusion.

I suppose if 1.33 doesn't drop in a long while we could consider MrAnderson-ing SnakeYaml. But no need to entertain that yet.