search

clj-commons / durable-queue

a disk-backed queue for clojure
Eclipse Public License 1.0
384 stars 31 forks source link

Update to Clojure 1.8 - byte-streams 0.2.2 #10

Open drbobbeaty opened 8 years ago

drbobbeaty commented 8 years ago

I'm starting to work with this library and Clojure 1.8.0, and as-is, this isn't working well - but if I preload the byte-streams v0.2.2 and exclude that from durable-queues, then it seems to work just fine.

I would suggest upgrading to [byte-streams "0.2.2"] in this project, and then it should be fine.

jaju commented 8 years ago

@drbobbeaty - Just curious. I am using durable-queue, and am using 1.9.0-alpha10. Haven't seen anything weird for small runs. What do you mean by "isn't working well?"

Thanks.

drbobbeaty commented 8 years ago

That the version of byte-streams needs to be updated. A new clojure dev might not know to exclude the older version from this library, and preload the newer one. Given the relationship of the authors (same guys :) it seems a simple fix for this library.

That's it. Just the version, as I've noted.

ztellman commented 8 years ago

What is the issue you're seeing, specifically? I wouldn't have guessed there would be an issue. On Tue, Jul 19, 2016 at 11:20 AM Bob Beaty notifications@github.com wrote:

That the version of byte-streams needs to be updated. A new clojure dev might not know to exclude the older version from this library, and preload the newer one. Given the relationship of the authors (same guys :) it seems a simple fix for this library.

That's it. Just the version, as I've noted.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Factual/durable-queue/issues/10#issuecomment-233577074, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB6PwCL_ZAoEHhN2Ok8RxM_-Zbt7H36ks5qXJb5gaJpZM4I8PzA .

drbobbeaty commented 7 years ago

Sorry... just saw this...

There is no breaking issue with the code. This is simply a lein deps :tree issue where you see the conflict in the versions.

The code runs, but in a large project, it's a little more maintenance than necessary.