search

clj-commons / gloss

speaks in bytes, so you don't have to
Eclipse Public License 1.0
483 stars 57 forks source link

Update byte-streams and fix gloss.data.bytes.delimited/match-loop eval #56

Closed skynet-gh closed 2 years ago

skynet-gh commented 2 years ago

Update byte-streams to 0.3.0 and use clj-commons.byte-streams namespace instead of byte-streams.

Rewrite gloss.data.bytes.delimited/match-loop to not use eval.

Tests

$ lein test

...

Ran 20 tests containing 3497 assertions.
0 failures, 0 errors.
skynet-gh commented 2 years ago

@KingMob can you take a look at this one when you get a chance? Thanks!

KingMob commented 2 years ago

Looks good. I'm not an admin of gloss, though, so I'm waiting on that first, so we can merge instead of squashing/rebasing in this case.