search

clj-commons / hickory

HTML as data
Other
637 stars 52 forks source link

Upgraded to latest ClojureScript and clojurescript.test. #11

Closed jeluard closed 10 years ago

jeluard commented 10 years ago

Runners are not explicitly required anymore.

davidsantiago commented 10 years ago

Thanks for the update. Can you tell me what this means for the runners? In terms of running tests or building or what not?

Also, I see that you made some changes to the way you handle the doc string. Looks fine, but a heads up in the commit message that there was a change there would be helpful in the future. Finally, you appear to have added a require for goog.string.format, but don't appear to have made a change that uses it. Is that right?

David

jeluard commented 10 years ago

Sorry the comment was a little bit scarce.

With the latest clojurescript.test a default runner (the one which was used for hickory) is automatically extracted/deleted so a local copy is no more needed.

Also I updated to latest ClojureScript which has better handling of unused imports (both thrown-with-msg?) but removed the implementation of format. It's been removed because it does not provide a complete equivalent of the Java counterpart. Here it's fine because the use case is pretty basic.

davidsantiago commented 10 years ago

Sorry this took me so long to get to, hopefully not too terrible for you. I took your PR, but I removed your abstraction of the format function for clojurescript. The reason is, there's no abstraction there. The function is not implemented on clj, and really, it's a little dangerous to have a function that appears to be the same as the clj function but actually isn't. Pushed a release to clojars.

Thanks again!

jeluard commented 10 years ago

Thanks for the merge!