Incorrect suggestion when using reducers

clj-commons / kibit

There's a function for that!

1.76k stars 135 forks source link

Incorrect suggestion when using reducers #245

Open Kineolyan opened 3 years ago

Kineolyan commented 3 years ago

When using reducer methods instead of standard map or filter, kibit seems to get confused. With the following code, kibit suggests to replace into [] by vec:

(into [] (r/filter even? (r/map inc (range 10))))

However, this is not valid as vec is not a supported collection producer, unlike into.

If you need, I can provide the small lein project I cooked to test this.

Additional info

Clojure version: 1.10.1 Kibit version via lein-kibit: 0.1.8

Kineolyan commented 3 years ago

Beyond this being an error, is there a way to tell kibit to ignore a function or a form? Currently, this is the only pattern that causes me issues. But this suggestion makes the whole lein kibit returns an error code, which makes it impossible to use as a CI check.