search

clj-commons / manifold

A compatibility layer for event-driven abstractions
1.02k stars 106 forks source link

d/alt docstring wrong? #205

Closed DerGuteMoritz closed 3 years ago

DerGuteMoritz commented 3 years ago

The docstring for d/alt says:

Values appearing earlier in the input are preferred.

I understand this to mean that the given arguments are checked from left to right (as in core.async/alt! with :priority true). However, the implementation actually randomizes the order. From https://github.com/clj-commons/manifold/pull/102 I gather that this was changed during review but the docstring wasn't adjusted accordingly.

KingMob commented 3 years ago

Good catch. Feel free to submit a PR, otherwise, I'll fix it in the next couple weeks.