search

clj-commons / manifold

A compatibility layer for event-driven abstractions
1.01k stars 106 forks source link

core.async 1.6.673 breaks `go-off` #229

Closed KingMob closed 1 year ago

KingMob commented 1 year ago

From Slack:

I just tried upgrading some deps, and noticed that the latest version of core.async, 1.6.673, breaks Manifold's go-off macro, which depends on some undocumented fns to reuse the same IOC machinery. Initially, it looks like the fns were just moved around internally, but since the major change in the latest version of core.async involves dynamic loading of the go analyzer, it's possible that bigger changes are required. I think we can just resolve what we need. But in the worst-case scenario, we either copy the relevant core.async code unmodified, which I believe the EPL allows (but IANAL), or we make go-off a separate repo under a different license. For now, anyone using go-off should avoid upgrading to core.async 1.6.673+.

KingMob commented 1 year ago

@tanzoniteblack Are you interested in helping? Do you know of anyone at Yummly who should be pinged too/instead?