search

clj-commons / manifold

A compatibility layer for event-driven abstractions
1.02k stars 108 forks source link

Fix param name #59

Closed lvh closed 8 years ago

lvh commented 8 years ago

Also, I'm trying to understand how connect-via works. Is it "if callback returns deferred false, drops on floor; otherwise passes on to provided sink"? If so, perhaps I should reword the docstring as well; the wording reads to me as if this passing-on happens unconditionally right now.

ztellman commented 8 years ago

If the callback returns false, the downstream sink is assumed to be closed, and the connection is severed.

lvh commented 8 years ago

Cool. I'm editing these through GitHub, so a separate PR would be marginally easier for me to do if that's OK with you.

ztellman commented 8 years ago

That's fine. I'll merge this one now.