d/finally function doesn't work in some cases

clj-commons / manifold

A compatibility layer for event-driven abstractions

1.02k stars 108 forks source link

d/finally function doesn't work in some cases #86

Closed OlegTheCat closed 8 years ago

OlegTheCat commented 8 years ago

The implementation of d/finally' function seems to be not strictly correct. In particular, this part. Obviously, if x is error deferred, the function with which it is chained isn't going to be called.

Test that reproduces the issue along with the fix are added.

ztellman commented 8 years ago

Hi, sorry for the delay in merging this, I was away. Thanks for catching this.