search

clj-commons / marginalia

Ultra-lightweight literate programming for clojure inspired by docco
https://clj-commons.org/marginalia/
813 stars 82 forks source link

Marginalia waits a long time for agents to shut down #159

Closed eigenhombre closed 6 years ago

eigenhombre commented 8 years ago

Marginalia should probably call shutdown-agents when it finishes, in any of the top-level forms cause futures to be spawned. lein marg on one project I tested sits and waits for ~60 seconds which shutdown-agents should avoid.

gdeer81 commented 6 years ago

Thanks for reporting this. Do you have an example codebase I can test against? I'll put this one on the roadmap for 9.2

eigenhombre commented 6 years ago

That looks like that should do it... thank you very much!

On Nov 14, 2017, at 12:09 AM, Gary Deer notifications@github.com wrote:

Closed #159 https://github.com/gdeer81/marginalia/issues/159 via 7d4a5c8 https://github.com/gdeer81/marginalia/commit/7d4a5c8c61fcc4190b3c8bb333d6e47080106e63.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gdeer81/marginalia/issues/159#event-1340180692, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXWzHSV9tdND0NWR2sAqz5u4jUlXsKiks5s2S6OgaJpZM4GOCy_.