Prevent all reflection across the library.

clj-commons / metrics-clojure

A thin façade around Coda Hale's metrics library.

http://metrics-clojure.rtfd.org/

MIT License

343 stars 82 forks source link

Prevent all reflection across the library. #115

Closed pyr closed 7 years ago

pyr commented 7 years ago

Standardize on *warn-on-reflection* to true for the dev profile
Fix metrics.health.core/check (previously called protected method check instead of execute).
Fix metrics.reporters.influxdb (previously called setGuages instead of setGauges)

michaelklishin commented 7 years ago

Thank you!

pyr commented 7 years ago

Thanks, that was quick!

michaelklishin commented 7 years ago

I assume points 2 and 3 deserve a bug fix release?

pyr commented 7 years ago

Yup, I think it's warranted. One think to arbitrate on is that the Guage/Gauge typo is still present in the options map (i.e: it still has :keys [group-guages]). I left it there in case someone somewhere feeds :group-guages in the option map. Going from 2.8.0 to 2.9.0 might warrant fixing the spelling in options too.

michaelklishin commented 7 years ago

@pyr let's fix that and go straight to 2.9.0.