Clojure maps are iterable

clj-commons / potemkin

some ideas which are almost good

572 stars 53 forks source link

Clojure maps are iterable #39

Closed joegallo closed 9 years ago

joegallo commented 9 years ago

Potemkin maps claim to be Iterable (because they implement clojure.lang.IPersistentMap, which is Iterable), but they don't actually have an implementation of .iterator. I've added a simple one, it seems to work, I think.

I came across this by way of https://github.com/dakrone/clj-http/issues/266

Leonidas-from-XIV commented 9 years ago

Now that Clojure 1.7 has been released, it would be great to have this issue fixed, so clj-http can support Clj 1.7 fully. Is there anything stopping this from being merged, I could maybe lend a hand to get this in?

ztellman commented 9 years ago

Yes, definitely. I'm currently traveling, but I will bundle up all the dangling changes for Potemkin into a new release within the week.

Leonidas-from-XIV commented 9 years ago

Thank you, looking forward to it! Have a good trip!