search

clj-commons / secretary

A client-side router for ClojureScript.
773 stars 64 forks source link

Fix extend type syntax #69

Closed noonian closed 9 years ago

noonian commented 9 years ago

…profile

The IRenderRoute implementations in extend-type forms had invalid syntax. Recent versions of cljs emit a warning for this now. See http://dev.clojure.org/jira/browse/CLJS-667 and http://dev.clojure.org/jira/browse/CLJS-104.

Without the fix you'll see these warnings running the tests with cljs 0.0-3211

$ lein run-tests
    ...
WARNING: Bad extend-type method shape for protocol IRenderRoute method -render-route, method arities must be grouped together at line 229 src/secretary/core.cljs
WARNING: Bad extend-type method shape for protocol IRenderRoute method -render-route, method arities must be grouped together at line 296 src/secretary/core.cljs
    ...