URIs prefixed with "#" don't comply the spec

clj-commons / secretary

A client-side router for ClojureScript.

773 stars 64 forks source link

Closed piotr-yuxuan closed 5 years ago

piotr-yuxuan commented 7 years ago

The syntax of an URI is defined as:

scheme:[//[user:password@]host[:port]][/]path[?query][#fragment]

Prefixing the URI by a # makes fragment hides the query. For instance:

https://www.example.com/path/of/app#path/inside/app?query=params&as=defined&by=secretary

fragment: "path/inside/app?query=params&as=defined&by=secretary" for standard libraries but is "path/inside/app" according to Secretary
query: "" but is "query=params&as=defined&by=secretary" according to Secretary

noprompt commented 7 years ago

Thanks for sharing this. I wasn't aware of this information. If you add the above information to the README I will merge this.

piotr-yuxuan commented 6 years ago

@noprompt ?

piotr-yuxuan commented 6 years ago

up?

borkdude commented 5 years ago

Since @noprompt gave the OK in this PR, I'll merge it now.