search

clj-commons / secretary

A client-side router for ClojureScript.
773 stars 64 forks source link

Wrong :require keyword usage in README example #98

Closed liaowang11 closed 5 years ago

liaowang11 commented 6 years ago

According to When do I use :require vs :import?.

:require goog.history.EventType and accessing the enum like EventType/NAVIGATE is not right.

Should indeed do a :import goog.history.EventType then access the enum like EventType.NAVIGATE.

borkdude commented 5 years ago

@liaowang11 PR welcome