search

clj-commons / virgil

Recompile Java code without restarting the REPL
312 stars 21 forks source link

run the first recompile synchronously #17

Closed schmir closed 6 years ago

schmir commented 6 years ago

The jsonista project is using virgil when running tests.

Make sure the first recompilation is done, before giving control back from virgil.

fixes issue #15

schmir commented 6 years ago

I've rebased the branch on current master, so this can easily be merged.

16cbc7e8bc4b4e90961507 introduced a second call to recompile. I don't think that's necessary and could be removed (though I did not do that in this pull request). (see https://github.com/ztellman/virgil/commit/16cbc7e8bc4b4e9096150710f0cc3e289410b07a#diff-6761ef9be36fd59cf156bc26d5cc3f6dR51)

ztellman commented 6 years ago

Thanks, I'm not quite sure what I was thinking with the extra recompile there.