Update ASM version to 8.0.1 so Virgil keeps working with newer JDK versions. - Githubissues

clj-commons / virgil

Recompile Java code without restarting the REPL

306 stars 21 forks source link

Update ASM version to 8.0.1 so Virgil keeps working with newer JDK versions. #31

Closed EmmanuelOga closed 4 months ago

EmmanuelOga commented 4 years ago

Updates the ASM version. ASM would otherwise would fail with an error:

unsupported class file major version 57.

Updates instructions for deps.edn users (the watch can just be run from the REPL).

Note

In case this patch is wrong for some reason, I also was able to use virgil with deps.edn by excluding ASM from the deps:

{:paths
 ["src" "test" "classes" "resources" "java"]

 :deps
 {virgil {:mvn/version "0.1.9" :exclusions [org.ow2.asm/asm] }
  org.ow2.asm/asm {:mvn/version "8.0.1"}}}

(note the "java" folder needs to be added to paths too).

alexander-yakushev commented 4 months ago

Fixed now, thanks for the PR!