search

clj-easy / graal-build-time

Initialize Clojure classes at build time with GraalVM native-image
MIT License
130 stars 5 forks source link

Apply unique parent package transform across all path elements #17

Closed lread closed 3 years ago

lread commented 3 years ago

Formerly we were applying this transform against individual path elements which allowed for the possibility of packages parent and parent.child to be included.

I also decided to sort registered packages for repeatability. We always start with clojure, but the remaining packages are sorted by name.

To express this package scenario, I decided to re-org our integration tests. Our hello world app has moved from under test/ to the new test-hello-world/. This new setup should somewhat more reflect realworld usages.

lread commented 3 years ago

Note: did have failure on Windows, hence the ci commits. Don't understand why things failed on Windows. Guessing either deps download wonkiness or gha wonkiness.

borkdude commented 3 years ago

@lread I think the error you saw in CI was related to:

No such var: reader/read

and this relates to the first line workaround we have in build.clj.

borkdude commented 3 years ago

So you should really copy that line to your new build.clj to prevent such errors.

lread commented 3 years ago

Aha, did not notice that! Thanks, will do!

borkdude commented 3 years ago

Can we please not use force-pushes in this organization? It's very hard for me to see what is the delta compared to my previous review.

lread commented 3 years ago

I don't do force pushes after a pull request is created (if I did, it was not intentional). Should I not be doing them before I create a pull request either?

borkdude commented 3 years ago

Whoops, I misread, sorry.

lread commented 3 years ago

No problemo!

lread commented 3 years ago

That's a nasty tools.build issue, mysterious to diagnose the cause unless you are familiar with the symptom!