search

clj-holmes / clj-watson

clojure deps SCA
Eclipse Public License 2.0
83 stars 9 forks source link

Encourage nvd api key usage #99

Closed lread closed 2 months ago

lread commented 2 months ago

Clj-watson now exits with an error when running without an nvd api key.

A stubborn user can opt to proceed without an nvd api key by specifying --run-without-nvd-api-key (or :run-without-nvd-api-key true).

In this case clj-watson will emit a warning to remind the user that they really should be using an nvd api key.

Update README on this topic. Also tweaked README here and there with some edits. Gave GitHub Markdown alerts a whirl: https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#alerts

Closes #67

lread commented 2 months ago

Hi, @seancorfield! I'm looking forward to your feedback on this one!

lread commented 2 months ago

Thanks for the review @seancorfield! I've taken a shot at addressing your feedback. Lemme know if we need more tweaks.

seancorfield commented 2 months ago

Looks great, thank you!

seancorfield commented 2 months ago

Just realized these changes didn't make it into the changelog...

lread commented 2 months ago

Oops, good point! See #100