clj-python / libpython-clj

Python bindings for Clojure
Eclipse Public License 2.0
1.05k stars 68 forks source link

JDK-20 support #243

Open mhjort opened 1 year ago

mhjort commented 1 year ago

Should this library support JDK-20? With JDK-19 everything works. However, when upgrading to JDK-20 I get following error:

Caused by: java.lang.ClassNotFoundException: jdk.incubator.foreign.MemoryAddress
cnuernber commented 1 year ago

yes it should - jdk-20 has same foreign iface as jdk-19 so I guess the system is loading the wrong bindings.

sbenhaim commented 11 months ago

In JDK 20, jdk.incubator.foreign.MemoryAddress has been moved to java.lang.foreign.MemorySegment.

https://www.jrebel.com/blog/java-20-features

cnuernber commented 11 months ago

JDK-20 changed the API again. I would rather wait for the next long term release than keep updating. If someone wants to take a crack at it you need to fix it in dtype-next. Here is a reasonable place to start.