Predicates for quarters

clj-time / clj-time

A date and time library for Clojure, wrapping the Joda Time library.

Other

738 stars 162 forks source link

Closed ahmadnazir closed 6 years ago

ahmadnazir commented 6 years ago

Predicates for checking if the date belongs to any of the quarters in a year

seancorfield commented 6 years ago

Given:

These are just simple checks on the month
They have somewhat cryptic names (I know we say "Q1", "Q2", etc but these are still short and cryptic)
Companies often have a financial year that does not coincide with the calendar year and therefore their "Q1" may not be Jan/Feb/Mar
JodaTime has no support for quarters as far as I know

I would rather not accept these into the library. @michaelklishin your thoughts?

michaelklishin commented 6 years ago

@seancorfield I agree. The concept of yearly quarters does not work the same way for all companies and in all cultures.

@ahmadnazir thank you for your time!