search

cljdoc / cljdoc-check-action

GitHub Action for checking that CljDoc will be able to analyze the project successfully
Eclipse Public License 2.0
3 stars 0 forks source link

Advice for lein users potentially problematic? #6

Open lread opened 1 year ago

lread commented 1 year ago

The README advice for lein users currently recommends doing a lein install. This might have two negative side effects:

  1. depending on how the folks have setup CI caching, the installed dep might get cached
  2. there is a chance that the wrong version might get selected for the check

So why not recommend a lein jar for lein users instead?

And then we can use the same check usage advice as we do for deps.edn based projects.

holyjak commented 1 year ago

Absolutely!