Closed pithyless closed 9 years ago
Oh. That's bad and most likely my fault. Changed something in boot-cljs
with https://github.com/adzerk/boot-cljs/pull/39. I think I know where the error is and will fix it.
@pithyless Ok, I thought I new where the error is but I can't reproduce it here. Is there a chance you could put the project where this occurred on Github?
@martinklepsch I narrowed it down to adding just [cljsjs/react "0.12.2-3"]
to build.boot:
@pithyless thank you, that was very very helpful! I pushed a fix here: https://github.com/martinklepsch/boot-cljs.
If you clone that and run boot build-jar
inside the cloned directory it will be installed to your local Maven repo and you should be able to run boot dev
in the project you provided as a testcase.
If you could report back here that the problem is gone, that would also be helpful. @nblumoe I think this will also fix the problem you're having.
Oh, and @pithyless you should probably update your App Version of Boot to RC8, the binary that you you're using (RC4) is outdated (I'm surprised it works actually :))
boot -u
did not update the binary. I had not realized until today when trying to document the issue.Thanks again!
I learned how to build a local version of a library I need to depend on. I was looking for this earlier and I couldn't figure it out; we need to push this into some FAQ in the wiki :)
Maybe that's something that could be added to the "Boot for Leiningen users" page: https://github.com/boot-clj/boot/wiki/Boot-for-Leiningen-Users
It's also non-obvious that boot -u did not update the binary. I had not realized until today when trying to document the issue.
Have you read this? https://github.com/boot-clj/boot/wiki/Keeping-Boot-Up-to-Date If you did, feel invited to edit it to make that differentiation more clear.
This almost resolves my issue, as it's working now. However, the path isn't correct though:
TBH I don't understand yet WHY this is working, as react.inc.js
is present only in target/js
, not in the root folder. But still the web server serves it from localhost:3000/react.inc.js
Serving the build artifacts from a copy of /target
(to prevent loosing it's contents when running boot
) via boot serve -d <TARGET-COPY> wait
does not work (404 for localhost:3000/react.inc.js
). So, somehow boot build
makes the file available from the web server's root. Is this related to filesets maybe?
@nblumoe to be honest I'm not sure what's going on there.
We're in the middle of migrating this kind of stuff to use :foreign-libs
as it is provided in the latest version of Clojurescript so these features are likely to be removed from boot-cljs
anyways.
Works:
Broken:
Is this an issue with
boot-cljs
orboot-cljsjs
?