cljsjs / boot-cljsjs

Helper tasks to aid the packaging of JS dependencies for Clojurescript projects
66 stars 22 forks source link

Weird directory structure #51

Open binarykitchen opened 6 years ago

binarykitchen commented 6 years ago

I have for example tried this in a new fork

(deftask package []
  (comp
    (download :url     (format "https://unpkg.com/@microsoft/office-js@%s/dist/office.debug.js" +lib-version+)
              :target  "cljsjs/office-js/development/office-js.inc.js")
    (download :url     (format "https://unpkg.com/@microsoft/office-js@%s/dist/office.js" +lib-version+)
              :target  "cljsjs/office-js/production/office-js.min.inc.js")
    (sift :include #{#"^cljsjs"})
    (pom)
    (show :fileset true)
    (jar)
    (validate-checksums)))

but output is very wrong

└─❱❱❱ boot package install target                                                                                                                                                              +7763 17:09 ❰─┘
Downloading office.debug.js
Sifting output files...
Downloading office.js
Sifting output files...
Sifting output files...
Writing pom.xml and pom.properties...

├── META-INF
│   └── maven
│       └── cljsjs
│           └── office-js
│               ├── pom.properties
│               └── pom.xml
└── cljsjs
    ├── cljsjs
    │   └── office-js
    │       └── production
    │           └── office-js.min.inc.js
    │               ├── common
    │               │   └── cljsjs
    │               │       └── office-js
    │               │           └── production
    │               │               └── office-js.min.inc.js.ext.js
    │               └── development
    │                   └── cljsjs
    │                       └── office-js
    │                           └── production
    │                               └── office-js.min.inc.js.inc.js
    └── office-js
        └── production
            └── office-js.min.inc.js
Writing office-js-1.1.8-0.jar...
Checksums match
Installing office-js-1.1.8-0.jar...
Writing target dir(s)...

Trying to understand what causes this wrong directory structure? Why is there so much nesting?

Thanks for any clues

binarykitchen commented 6 years ago

When I am trying to use :name instead I think there is a bug in the download task at (re-pattern fname) which probably should be quoted or so. And it it's a regex, it looks weird when printed in console