cljsjs / boot-cljsjs

Helper tasks to aid the packaging of JS dependencies for Clojurescript projects
66 stars 22 forks source link

it is valid for :global-exports key to be a string #60

Closed henryw374 closed 4 years ago

henryw374 commented 4 years ago

the deps-cljs task specs global-exports as a map of {sym sym}, but I think keys ought to be able to be strings as well. see https://clojure.atlassian.net/browse/CLJS-3138

Error:

option :global-exports must be of type {sym sym}
Deraen commented 4 years ago

Global-exports task option is deprecated, use foreign-libs option instead:

https://github.com/cljsjs/boot-cljsjs/blob/master/src/cljsjs/boot_cljsjs/packaging.clj#L208 https://github.com/cljsjs/packages/blob/master/react-sortable-hoc/build.boot#L27-L34

henryw374 commented 4 years ago

thanks